Allow configuring rustfix::Filter independently of the mode#148
Merged
oli-obk merged 1 commit intooli-obk:mainfrom Aug 25, 2023
Merged
Allow configuring rustfix::Filter independently of the mode#148oli-obk merged 1 commit intooli-obk:mainfrom
rustfix::Filter independently of the mode#148oli-obk merged 1 commit intooli-obk:mainfrom
Conversation
Owner
|
Needs rustfmt, otherwise lgtm. |
Alexendoo
force-pushed
the
rustfix-configurable-filter
branch
from
0a6455d to
203c436
Compare
Contributor
Author
|
Ahh I was still on 1.71 Looks like MIRI uses Yolo in some form, not sure on the context how necessary it is though |
Owner
|
I can publish on Monday, or, if you open a PR with version bumps, I can tell GHA to publish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since rust-lang/rust-clippy#11249 was merged we'll be wanting to move clippy from
YolotoFailto make the annotations required, but we still want to apply non machine applicable suggestions so this adds an enum to configure rustfixcc @GuillaumeGomez since rust-lang/rust-clippy#11249 (comment) will be blocked on this